Skip to content

Ensure containers are healthy for gitaly e2e tests

John McDonnell requested to merge jmd-improve-stability-of-gitaly-e2e-tests into master

Description of the test

There's been a number of tests failing intermittently related to the gitaly-cluster tests. From observing the logs it would appear that some of the failures are being caused by docker containers either not running, or not being completely ready to serve requests when the test attempts to run. This MR aims to improve the resilience of the tests, by always ensuring that we restart any containers that may be in a 'stopped' state for any reason.

Check-list

  • Confirm the test has a testcase: tag linking to an existing test case in the test case project.
  • Note if the test is intended to run in specific scenarios. If a scenario is new, add a link to the MR that adds the new scenario.
  • Follow the end-to-end tests style guide and best practices.
  • Use the appropriate RSpec metadata tag(s).
  • Ensure that a created resource is removed after test execution. A Group resource can be shared between multiple tests. Do not remove it unless it has a unique path. Note that we have a cleanup job that periodically removes groups under gitlab-qa-sandbox-group.
  • Ensure that no transient bugs are hidden accidentally due to the usage of waits and reloads.
  • Verify the tags to ensure it runs on the desired test environments.
  • If this MR has a dependency on another MR, such as a GitLab QA MR, specify the order in which the MRs should be merged.
  • (If applicable) Create a follow-up issue to document the special setup necessary to run the test: ISSUE_LINK
  • If the test requires an admin's personal access token, ensure that the test passes on your local with and without the GITLAB_QA_ADMIN_ACCESS_TOKEN provided.
Edited by John McDonnell

Merge request reports