Skip to content

Make wording in security report summaries more consistent

Lukas Eipert requested to merge 6079-ignore-dismissed-issues-in-count into master

What does this MR do?

I started cleaning up the secure report summary generation code in preparation for #6079 (closed). It is better translatable now, and I reduced a lot of code duplication, and I actually fixed #7383 (closed) along the way 😅

Before After Description
Screen_Shot_2018-08-29_at_17.34.04 Screen_Shot_2018-09-14_at_18.51.54 If the base has security vulnerabilities, but the base does not, we will say no new vulnerabilities in the grouped header. Additionally we removed security from the individual reports, as it seemed redundant
Screen_Shot_2018-09-14_at_18.57.13 Rewording of the error message
Rewording of the message when both new and fixed vulnerabilities exist

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Lukas Eipert

Merge request reports