Revert "make the package and qa always manual"
What does this MR do and why?
Revert "make the package and qa always manual"
This reverts commit b6ce1384.
This is required as it is preventing FOSS from performing builds which in turn, prevents omnibus from being able to build the CE version
Describe in detail what your merge request does and why.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
requested review from @mayra-cabrera and @godfat-gitlab
assigned to @skarbek
mentioned in issue gitlab-org/release/tasks#3058 (closed)
- A deleted user
added Engineering Productivity label
3 Warnings Please add a merge request type to this merge request. This merge request does not refer to an existing milestone. Most of the time, merge requests should target master
. Otherwise, please set the relevantPick into X.Y
label.2 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 73675 "Revert "make the package and qa always manual""
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 73675 "Revert "make the package and qa always manual""
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach. To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a
Changelog
trailer to it. For example:This is my commit's subject line This is the optional commit body. Changelog: added
The value of the
Changelog
trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other.For more information, take a look at the following resources:
https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1564
- https://docs.gitlab.com/ee/api/repositories.html#generate-changelog-data
If you'd like to see the new approach in action, take a look at the commits in the Omnibus repository.
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer Engineering Productivity for CI, Danger Ash McKenzie ( @ashmckenzie
) (UTC+11, 15 hours ahead of@skarbek
)Rémy Coutable ( @rymai
) (UTC+1, 5 hours ahead of@skarbek
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for 73bd62d7 succeeds
mentioned in commit bbb53251