Match address of host when checking whether to login

What does this MR do and why?

When running Geo QA specs, ensures that we check we are logged into the correct host when determining whether we need to login or not.

Prior to this, we only checked if we are on a login page, which was passing when we were on the primary login page

Closes #349390 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

assigned to @ibaum

changed the description

added devopssystems groupgeo sectioncore platform labels

added QA label

	2 Warnings
	6f07681c: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	This MR has a Changelog commit for EE, but no code changes in ee/. Consider removing the EE: true trailer from your commits.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
QA	Tiffany Rea (@treagitlab) (UTC-8, 2 hours behind @ibaum)	Andrejs Cunskis (@acunskis) (UTC+1, 7 hours ahead of @ibaum)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• 76fca930 - Match address of host when checking whether to login

Compare with previous version

added 1 commit

• b4ea65b1 - Match address of host when checking whether to login

Compare with previous version

Allure report

allure-report-publisher generated test report for 6f07681c!

package-and-qa: test report
review-qa-all: test report
review-qa-smoke: test report
review-qa-reliable: test report

mentioned in issue #338713 (closed)

added 1 commit

• 9b6cc4ed - Move login to a better location

Compare with previous version

added 1 commit

• fb106222 - Don't check host if address is nil

Compare with previous version

added 1 commit

• 2deb7ff3 - Don't use named argument

Compare with previous version

added 1 commit

• c5755c41 - Adding debug message

Compare with previous version

added 1 commit

• 7e2b1192 - Adding more debugging info

Compare with previous version

added 1 commit

• 2330506d - Just visit the login page

Compare with previous version

added 1 commit

• e23fe7b7 - Even more debugging

Compare with previous version

In my dev environment, this is currently failing with an invalid session id. It looks like it is logging out of the primary node, but still not actually logging into the primary node. Need to debug further.

added 6402 commits

• e23fe7b7...3552280a - 6394 commits from branch master
• 7c74c3d1 - Match address of host when checking whether to login
• 89b8dc85 - Move login to a better location
• 8ee9dd24 - Don't check host if address is nil
• 1d949e04 - Don't use named argument
• 66a1f38e - Adding debug message
• 24780fcc - Adding more debugging info
• 1e309826 - Just visit the login page
• 4ba19d4c - Even more debugging

Compare with previous version

resolved all threads

This was missing some large changes, rebased and we're looking better.

• In my dev environment, I saw several failures due to timeout. I'm running a pipeline with a longer timeout by setting GEO_MAX_FILE_REPLICATION_TIME to 240

• The GET::Geo job is currently failing with a 403 error. Looks like the account it is using doesn't have permission to access the buckets for terraform state.

added 10 commits

• b4ea65b1 - Match address of host when checking whether to login
• 9b6cc4ed - Move login to a better location
• fb106222 - Don't check host if address is nil
• 2deb7ff3 - Don't use named argument
• c5755c41 - Adding debug message
• 7e2b1192 - Adding more debugging info
• 2330506d - Just visit the login page
• e23fe7b7 - Even more debugging
• 85ea091d - Merge branch 'qa-geo-check-address' of gitlab.com:gitlab-org/gitlab into qa-geo-check-address
• b8d99471 - Remove debugging info

Compare with previous version

mentioned in commit e58491d1

added 1 commit

• e58491d1 - Match address of host when checking whether to login

Compare with previous version

The package-and-qa job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/432183750 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/432190028 downstream.

The qa-test job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/432190028 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/432206100 downstream.

The gitlab-qa downstream pipeline failed! .

I think this is ready for review.

Ideally, the GET::Geo job would be a good indicator of the status, but it is currently failing due to an unrelated issue

Custom pipeline using these changes can be seen here

changed milestone to %14.7

added maintenanceworkflow label

added tooling (archive) label

changed the description

@treagitlab will you please do the initial review of this change?

requested review from @treagitlab

added 1 commit

• 5bc0bfa5 - Restore sign_in flow

Compare with previous version

The package-and-qa job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/433603382 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/433617051 downstream.

The qa-test job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/433617051 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/433642461 downstream.

added 1 commit

• 5ad0a63c - Make on_login_page check for the host as well

Compare with previous version

The package-and-qa job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/433672058 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/434214316 downstream.

The qa-test job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/434214316 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/434264553 downstream.

The gitlab-qa downstream pipeline failed! .

added 1 commit

• 8adac2b3 - Add missing address arg for sign_in check

Compare with previous version

The package-and-qa job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/435288345 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/435333706 downstream.

The qa-test job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/435333706 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/435352363 downstream.

The gitlab-qa downstream pipeline failed! .

added 1 commit

• 164dd89a - Apply 2 suggestion(s) to 2 file(s)

Compare with previous version

The package-and-qa job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/438623105 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/438634931 downstream.

The qa-test job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/438634931 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/438658965 downstream.

The gitlab-qa downstream pipeline failed! .

changed the description

added 1 commit

• ce74baf4 - Clean up redirect behavior

Compare with previous version

The package-and-qa job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/439248228 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/439258594 downstream.

The qa-test job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/439258594 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/439271862 downstream.

The gitlab-qa downstream pipeline failed! .

added 1 commit

• 6f07681c - Fix typo

Compare with previous version

The package-and-qa job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/439274575 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/439280292 downstream.

The qa-test job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/439280292 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/439290616 downstream.

The gitlab-qa downstream pipeline failed! .

The only login page failure was because of 502, the rest of the failures don't seem to be related. We are good here.

P/S: Perhaps, this can clear up once the branch is rebased and pipeline runs again.

The package-and-qa job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/442026230 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/442050268 downstream.

The qa-test job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/442050268 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/442082607 downstream.

The gitlab-qa downstream pipeline failed! .

approved this merge request

@treagitlab, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

unapproved this merge request

approved this merge request

@acunskis over to you for maintainer review

assigned to @acunskis

requested review from @acunskis

unassigned @acunskis

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for 90243b49 succeeds

merged

mentioned in commit cf96c74e

mentioned in commit d8d066de

added workflowstaging-canary label

added workflowstaging label and removed workflowstaging-canary label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

mentioned in issue gitlab-com/www-gitlab-com#9309 (closed)

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

mentioned in merge request kubitus-project/kubitus-installer!562 (merged)

added typemaintenance label and removed tooling (archive) label