Pass keyword args explicitly (!73457) · Merge requests · GitLab.org / GitLab · GitLab

Andrea Galbusera requested to merge gizero/gitlab:cascading-namespace-migration-helper-pass-kwargs-explicitly into master Nov 01, 2021

What does this MR do?

Updates a method call to pass keyword args explicitly instead of relying on automatic conversion that is deprecated in Ruby 3.

Without this fix, on branches introducing migrations that use the new cascading namespace migration helper to add database columns for new settings, a bunch of tests where observed to fail like in pipeline https://gitlab.com/gizero/gitlab/-/pipelines/398827751 (see https://gitlab.com/gizero/gitlab/-/jobs/1732315129, https://gitlab.com/gizero/gitlab/-/jobs/1732315132 and others). It was observed in the context of !58172 (closed), but could affect any user of the new migration helper.

This patch explicitly double splats the keyword args when calling add_column().

Does this MR meet the acceptance criteria?

Conformity

I have self-reviewed this MR per code review guidelines.
I have followed the style guides.