Exclude project namespace when computing subgroup counts
What does this MR do and why?
When loading counts for group lists exclude project namespaces from subgroup counts
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.5
assigned to @acroitor
- A deleted user
added backend label
1 Warning Please add a merge request type to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alina Mihaila ( @alinamihaila
) (UTC+2, same timezone as@acroitor
)Sean McGivern ( @smcgivern
) (UTC+0, 2 hours behind@acroitor
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Alexandru Croitor
@digitalmoksha would you be up to reviewing this ?
requested review from @digitalmoksha
Setting label groupproject management based on
@acroitor
's group.added groupproject management label
Setting label(s) devopsplan sectiondev based on groupproject management.
added devopsplan sectiondev labels
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
@acroitor looks great! Nothing blocking, just a few questions. Going ahead an approving
removed review request for @digitalmoksha
@digitalmoksha
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in merge request !73351 (merged)
added 351 commits
-
faebee4e...337207b3 - 350 commits from branch
master
- ca700fdd - Exclude project namespace when computing subgroup counts
-
faebee4e...337207b3 - 350 commits from branch
added auto updated devopsfoundations missed:14.4 workflowin dev + 1 deleted label and removed devopsplan groupproject management labels
- Resolved by charlie ablett
@cablett up for a maintainer review?
requested review from @cablett
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
added 1 commit
- 9f1d766a - Exclude project namespace when computing subgroup counts
Awesome work @acroitor
LGTM. New pipe started and MWPS setenabled an automatic merge when the pipeline for 8c257dfe succeeds
mentioned in commit 466cf5fd
added workflowstaging-canary label and removed workflowin dev label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue gitlab-org/manage/general-discussion#17406
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels and removed devopsfoundations sectiondev + 1 deleted label