Rename whitelist method to allowlist DIB
What does this MR do and why?
- Renames method with
whitelist
toallowlist
per https://about.gitlab.com/handbook/communication/top-misused-terms/
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Closes #343319 (closed)
Merge request reports
Activity
changed milestone to %14.5
added auto updated workflowin dev + 1 deleted label
assigned to @dstull
added typefeature label
removed typefeature label
added typemaintenance label
- A deleted user
added backend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Mark Fletcher ( @markglenfletcher
) (UTC+0, 4 hours ahead of@dstull
)Matthias Käppler ( @mkaeppler
) (UTC+1, 5 hours ahead of@dstull
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Alex Pooley
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Alex Pooley
@dblessing can you please review?
requested review from @dblessing
- Resolved by Alex Pooley
strange...I can see how https://gitlab.com/gitlab-org/gitlab/-/jobs/1726968226 is related due to http://gitlab.com/gitlab-org/gitlab/blob/8b8608df0bd135c98d5ceac1068ac41ae46a7c2d/app/controllers/import/gitlab_groups_controller.rb#L12-12, but I'm not getting the same failure locally...rerunning new pipeline
added workflowin review label and removed workflowin dev label
Setting label(s) devopsgrowth sectiongrowth based on groupexpansion.
added devopsgrowth sectiongrowth labels
requested review from @proglottis and removed review request for @dblessing
@dblessing
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @alexpooley and removed review request for @proglottis
enabled an automatic merge when the pipeline for f212409b succeeds
mentioned in commit e94f48e8
added workflowstaging-canary label and removed workflowin review label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label