Draft: Relocate and retag test for mixed deployment refactor
What does this MR do and why?
Moves mixed environment tests into their own folder to prevent tests leaking into other jobs. Response to pipeline deployment changes requiring we alter our existing approach.
Was initially going to quarantine until the refactor was complete, thus the branch name. However, completed the refactor so renamed and repurposed this MR.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Closes #344213 (closed)
Merge request reports
Activity
changed milestone to %14.5
assigned to @zeffmorgan
Allure report
allure-report-publisher
generated test report for 70e76226!review-qa-smoke:
test report
review-qa-all: test report
package-and-qa: test reportadded 288 commits
-
cbf17ca5...0eb0e6a9 - 286 commits from branch
master
- 83d15b22 - Quarantines test until refactor complete
- 8f94fdda - Move spec and add run type
-
cbf17ca5...0eb0e6a9 - 286 commits from branch
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/399315305 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/399316776 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/399316776 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/399324274 downstream.The
gitlab-qa
downstream pipeline failed! .
requested review from @willmeek
@willmeek your name came up in the rotation ... do you have a moment for a quick (early) review? This change does three small things to a small test:
- Relocates it to its own subfolder to segregate it from being run by other jobs (like secure and geo tests)
- Changes the tag (we changed the tagging strategy for selection to allow an opportunity to give burn in time to this new kind of smoke test)
- Limits the test to the staging subdomain (the only location it can run from - this is a new test for mixed deployment environments)
I will have to make a small update to the tags list, which isn't done yet, but shouldn't hold this back.
The current pipeline isn't finished, but previous pipeline runs were expected results.
Edited by Zeff Morgan@zeffmorgan do we want to progress this MR? I approved a while back, but it looks like it needs conflicts resolved.
@willmeek thanks for checking in on this. This is actually on hold until we resolve some other items. I will pick this back up after we complete the rest of our related work.
Actually, @willmeek, I'm so glad you pointed this out. I completely forgot I had rolled another small change into this that should be in there. I'll split that out and at least get that done.
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/399647636 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/399663639 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/399663639 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/399685148 downstream.The
gitlab-qa
downstream pipeline failed! .
@willmeek
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in issue #341427 (closed)
removed review request for @willmeek
changed milestone to %14.6
added missed:14.5 label
changed milestone to %14.7
added missed:14.6 label
mentioned in issue #344213 (closed)
changed milestone to %14.8
added missed:14.7 label
changed milestone to %14.9
added missed:14.8 label
1 Warning Please add a merge request type to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA Will Meek ( @willmeek
) (UTC+0, 5 hours ahead of@zeffmorgan
)Ramya Authappan ( @at.ramya
) (UTC+5.5, 10.5 hours ahead of@zeffmorgan
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in merge request !82161 (closed)
changed milestone to %14.10
added missed:14.9 label
changed milestone to %15.0
added missed:14.10 label
changed milestone to %15.1
added missed:15.0 label
changed milestone to %15.2
added missed:15.1 label
- Resolved by 🤖 GitLab Bot 🤖
@zeffmorgan - please add typebug typefeature, typemaintenance or a subtype label to this merge request.- typebug: Defects in shipped code and fixes for those defects. This includes all the bug types (availability, performance, security vulnerability, mobile, etc.)
- typefeature: Effort to deliver new features, feature changes & improvements. This includes all changes as part of new product requirements like application limits.
- typemaintenance: Up-keeping efforts & catch-up corrective improvements that are not Features nor Bugs. This includes restructuring for long-term maintainability, stability, reducing technical debt, improving the contributor experience, or upgrading dependencies.
See the handbook for more guidance on classifying.
This message was created with automation and Engineering Productivity is looking for feedback in this issue:
https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues/43
added maintenancetest-gap label
added typemaintenance label
changed milestone to %15.3
added missed:15.2 label