Skip to content

Fix filtering of "Not connected" runners

What does this MR do and why?

This change (hack) replaces the space with a special space char in the "Not connected" option that filters runners. This change is needed because the version with quotes ("") does not locate the right value in the options list to pass to the filters and the URL.

Screenshots or screen recordings

before after
2021-10-29_10.42.31 2021-10-29_11.03.21

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Visit the admin -> runners page http://gdk.test:3000/admin/runners
  2. Search by status
  3. Select a "Not connected" status
  4. No errors should appear, and not connected runners should be visible.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344142 (closed)

Edited by Miguel Rincon

Merge request reports