Update GitLab UI/SVG
This MR contains the following updates:
Package | Type | Update | Change |
---|---|---|---|
@gitlab/svgs (source) | dependencies | minor | 1.218.0 -> 1.219.0 |
@gitlab/ui (source) | dependencies | minor | 32.21.0 -> 32.28.0 |
MR created with the help of gitlab-org/frontend/renovate-gitlab-bot
Release Notes
gitlab-org/gitlab-ui
v32.28.0
Features
- css: Use px in breakpoints instead of rem (d107ae6)
v32.27.0
Features
- GlBanner: Add embedded prop to gl-banner (e0669e3)
v32.26.0
Features
- breadcrumb: Set default separator and fix spacing (95a7fc8)
v32.25.0
Features
- css: Add gl-top-8 utility class (40a6aba)
32.24.1 (2021-10-26)
Bug Fixes
- revert components'
.documentations.js
files (5fbcd1f)
v32.24.1
Bug Fixes
- revert components'
.documentations.js
files (5fbcd1f)
v32.24.0
Features
- css: Add 5% width mixin (6eaa25a)
v32.23.0
Features
- Tabs: Update disabled color (c0fbf11)
v32.22.0
Features
- segmented-control: Update styles to match UI Kit (4aaf666)
Configuration
-
If you want to rebase/retry this MR, check this box.
This MR has been generated by Renovate Bot.
Merge request reports
Activity
Renovate Comment
This Merge Request has been created with the help of renovate-gitlab-bot project.
What are the next steps?
If you have been assigned as a reviewer to this Merge Request, please review this Merge Request with the same scrutiny as any community contribution:
-
Ensure that the dependencies updated meet our standards:
- Security: Dependencies do not contain malicious code
- Performance: Dependencies do not bloat the application code or prolong CI times unnecessarily
- Stability: Pipelines are passing
-
If tests are passing and you've reviewed the updated dependencies, execute pipelines in the context of the main project
This MR is created from a fork, therefore not all jobs (e.g. Danger) might have been executed. Instead of hitting MWPS right away, you might want to wait until the pipeline you've just triggered finished.
Note: This might not be available in projects, in that case merging right away is an option
-
Merge away!
Troubleshooting
We have assembled some [FAQs] to help reviewers of these kind of merge requests.
Improve this message – The JSON comment below is for automation purposes.
[FAQs]:
{"labels":["frontend","dependency update","feature::maintenance"],"assignees":["@dmishunov","@ealcantara","@pgascouvaillancourt","@sarahghp","@mikegreiling","@ohoral","@markrian"]}
-
assigned to @pgascouvaillancourt
assigned to @dmishunov
added frontend maintenancedependency + 1 deleted label
requested review from @ohoral and @ealcantara
added typefeature label
assigned to @mrincon and unassigned @pgascouvaillancourt
- Resolved by Olena Horal-Koretska
I'll add myself as an assignee to support this update effort, now that gitlab-ui!2414 (merged) is merged. cc @dmishunov @leipert
added typemaintenance label and removed typefeature + 1 deleted label
mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!2607 (merged)
changed milestone to %14.6
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/new_namespace/new_namespace_page.vue
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Jannik Lehmann ( @jannik_lehmann
) (UTC+1)Phil Hughes ( @iamphill
) (UTC+0)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #343954 (closed)
added 247 commits
-
a0ba22d1...871ef67a - 245 commits from branch
gitlab-org:master
- 8d33020f - Update GitLab UI/SVG
- 351db506 - Update snapshots and startup CSS
-
a0ba22d1...871ef67a - 245 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7425693f and 5d05b3d8
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.23 MB 3.24 MB +5.37 KB 0.2 % mainChunk 1.88 MB 1.88 MB - 0.0 % Significant Growth: 5Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.registrations.update_registration 975 Bytes 4.8 KB +3.85 KB 404.1 % pages.registrations.welcome 1.46 KB 5.31 KB +3.85 KB 263.9 % pages.registrations.projects.new 15.91 KB 19.14 KB +3.23 KB 20.3 % pages.registrations.groups_projects.new 17.85 KB 21.08 KB +3.23 KB 18.1 % pages.registrations.groups.new 54.63 KB 57.77 KB +3.14 KB 5.8 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for 7425693f. So we have used data from: 6654679e.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 5d05b3d8!review-qa-smoke:
test report- Resolved by Miguel Rincon
I am getting an odd rspec failure at https://gitlab.com/gitlab-org/gitlab/-/jobs/1729794292#L1371 that seems unrelated and I can't reproduce it in my local.
rspec ./spec/features/projects/new_project_spec.rb:50 # New project as an admin shows "New project" page
Edited by Miguel Rincon
mentioned in merge request gitlab-ui!2185 (merged)
changed milestone to %14.5
- Resolved by Olena Horal-Koretska
@ealcantara @ohoral The pipeline is passing so this is ready for your review! gitlab-ui!2414 (merged) Thanks a lot!
Edit: Please note this update includes this change: gitlab-ui!2414 (merged)
Edited by Miguel Rincon
- Resolved by Olena Horal-Koretska
@ohoral
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for e6a4ab02 succeeds
mentioned in merge request !72902 (closed)
mentioned in commit 8f92de9c
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!388 (merged)
added automation:bot-authored label