Skip to content

Remove skip_legacy_diff_note_callback_on_import from legacy diff note

Doug Stull requested to merge 343690-legacydiffnote-st_diff-being-set-incorrectly-some-of-the-time into master

What does this MR do and why?

  • through investigation of #343690 (closed) we found the likely reason for merge_request_diff_files differences when importing from GitHub for PRs that are referencing GitHub forks - #343690 (comment 714868633).
    • since this was the only reason for adding this feature flag(needed to investigate the reasons st_diff wasn't set correctly - #343664 (closed)) - we can now remove this feature flag.
  • LegacyDiffNotes should never need to set st_diff on import if they are already set since they are coming from an exported version of the project, which is correct.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #343690 (closed)

Edited by Doug Stull

Merge request reports