Skip to content
Snippets Groups Projects

Refactor error tracking gzip decompression

Merged Dmytro Zaporozhets (DZ) requested to merge dz-et-improve-gzip-support-2 into master
All threads resolved!

What does this MR do and why?

Error tracking has 2 endpoints: one of it uses middleware to decompress payload, another uses regular class. This MR makes both endpoints use the same middleware instead.

  1. Add application/x-sentry-envelope support to lib/gitlab/middleware/compressed_json.rb middleware
  2. Remove gzip decompression from lib/error_tracking/collector/sentry_request_parser.rb since we do it with middleware now.

We do this to remove code repetition.

No changes from user perspective.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dmytro Zaporozhets (DZ)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dmytro Zaporozhets (DZ)
  • Rémy Coutable added typemaintenance label and removed typefeature + 1 deleted label

    added typemaintenance label and removed typefeature + 1 deleted label

  • Drew Blessing approved this merge request

    approved this merge request

  • Drew Blessing requested review from @a_akgun

    requested review from @a_akgun

  • :wave: @dblessing, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Drew Blessing removed review request for @dblessing

    removed review request for @dblessing

  • Dmytro Zaporozhets (DZ)
  • Alper Akgun approved this merge request

    approved this merge request

  • Alper Akgun resolved all threads

    resolved all threads

  • Alper Akgun enabled an automatic merge when the pipeline for 30b0939f succeeds

    enabled an automatic merge when the pipeline for 30b0939f succeeds

  • merged

  • Alper Akgun mentioned in commit 54fdbba9

    mentioned in commit 54fdbba9

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading