Refactor error tracking gzip decompression
What does this MR do and why?
Error tracking has 2 endpoints: one of it uses middleware to decompress payload, another uses regular class. This MR makes both endpoints use the same middleware instead.
- Add
application/x-sentry-envelope
support tolib/gitlab/middleware/compressed_json.rb
middleware - Remove gzip decompression from
lib/error_tracking/collector/sentry_request_parser.rb
since we do it with middleware now.
We do this to remove code repetition.
No changes from user perspective.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @dzaporozhets
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Drew Blessing ( @dblessing
) (UTC-5, 7 hours behind@dzaporozhets
)Tetiana Chupryna ( @brytannia
) (UTC+3, 1 hour ahead of@dzaporozhets
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report for a67536c1!review-qa-smoke:
test reportadded 2587 commits
-
a67536c1...993ebdf8 - 2586 commits from branch
master
- 6c1b4d38 - Refactor error tracking gzip decompress
-
a67536c1...993ebdf8 - 2586 commits from branch
changed milestone to %14.5
added Category:Error Tracking devopsmonitor grouprespond labels
added typefeature label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Alper Akgun
@dblessing please review backend
requested review from @dblessing
- Resolved by Alper Akgun
- Resolved by Alper Akgun
added typemaintenance label and removed typefeature + 1 deleted label
requested review from @a_akgun
@dblessing
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added sectionops label
removed review request for @dblessing
- Resolved by Alper Akgun
enabled an automatic merge when the pipeline for 30b0939f succeeds
mentioned in commit 54fdbba9
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label