Promote empty_repo_upload experiment
What does this MR do and why?
Promote the empty_repo_upload experiment and remove the experiment code
part of: #332046 #335721 (closed)
How to set up and validate locally
-
Create a new project without a readme: http://localhost:3000/projects/new#blank_project uncheck "Initialize repository with a README"
-
Verify there is an "Upload File" button, and that it works.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.5
added groupadoption [DEPRECATED] label
assigned to @jayswain
1 Warning Please add a merge request type to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend George Koltsov ( @georgekoltsov
) (UTC+1, 8 hours ahead of@jayswain
)Sean McGivern ( @smcgivern
) (UTC+1, 8 hours ahead of@jayswain
)frontend Alexander Turinske ( @aturinske
) (UTC-6, 1 hour ahead of@jayswain
)Savas Vedova ( @svedova
) (UTC+3, 10 hours ahead of@jayswain
)test Quality for spec/features/*
George Koltsov ( @georgekoltsov
) (UTC+1, 8 hours ahead of@jayswain
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 409f5667 and 396f2c49
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.24 MB 3.24 MB - -0.0 % mainChunk 1.89 MB 1.89 MB - -0.0 %
Note: We do not have exact data for 409f5667. So we have used data from: 210552b2.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 396f2c49!review-qa-smoke:
test reportadded feature flag label
- Resolved by Jay
@andr3 will you run frontend review here, please?
@shreyasagarwal will you run backend review here, please?
requested review from @andr3
requested review from @shreyasagarwal
Setting label(s) devopsgrowth sectiongrowth based on groupadoption.
added devopsgrowth sectiongrowth labels
requested review from @mnichols1
requested review from @sming-gitlab and removed review request for @andr3
@andr3
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by James Fargher
@jayswain Apologies, I am quite occupied with few things lately. Hope you dont mind assigning another reviewer here.
removed review request for @shreyasagarwal
requested review from @zmartins
- Resolved by Jay
requested review from @proglottis
removed review request for @zmartins
removed review request for @sming-gitlab
requested review from @jivanvl
added workflowin review label
removed review request for @jivanvl
enabled an automatic merge when the pipeline for d3fd817b succeeds
mentioned in commit 6cc50efd
added workflowstaging-canary label and removed workflowin review label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
removed review request for @mnichols1
added workflowproduction label and removed workflowcanary label
mentioned in issue #335721 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!388 (merged)
added growth experiment label
added featureaddition label
added typefeature label
mentioned in merge request !125210 (merged)
mentioned in issue gitlab-com/gl-infra/scalability#2538