Skip to content

Remove extra space above empty messages on vulnerability report table

Daniel Tian requested to merge 338790-fix-extra-empty-spacing into master

What does this MR do and why?

On the vulnerability report, we show 2 types of empty messages in the vulnerability list:

  1. When the project has no vulnerabilities

  2. When the project has vulnerabilities, but the filters returned no results

These messages use the GlEmptyState component. There is a class that adds a top margin that looks correct when the component is shown by itself on a page, but causes the spacing to be off when it's shown inside a table:

ksnip_20211023-012758

This MR fixes the spacing so that the space above and below the message are the same.

Before After
ksnip_20211023-012758 ksnip_20211023-012638
ksnip_20211023-012913 ksnip_20211023-012854

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Daniel Tian

Merge request reports