Skip to content

Ensure Gitaly and Git binaries are built during test setup

Stan Hurequested to merge
sh-improve-gitaly-test-build-setup into master

What does this MR do and why?

!72366 (merged) modified the test setup to ensure the Git binary was built properly with Gitaly. However, scripts/gitaly-test-build would only attempt to call make gitaly git if the tmp/tests/gitaly path did not exist. This would cause a CI job with a stale cache to fail since git was not updated.

We now improve the logic by checking for the existence of the path and the required binaries:

  1. tmp/tests/gitaly
  2. tmp/tests/gitaly/bin/gitaly
  3. tmp/tests/gitaly/_build/deps/git/install/bin/git
Edited by Stan Hu

Merge request reports