Skip to content

Remove stage default from CI schema

Mireya Andres requested to merge ci-schema/stage-default into master

What does this MR do and why?

For #341600 (closed) and #335961 (closed)

The following changes are added to the CI schema for the pipeline editor:

Screenshots or screen recordings

stage

Before After
Before After

start_in

Screen_Shot_2021-10-21_at_12.26.16

How to set up and validate locally

  1. Enable the schema_linting feature flag (rails c then Feature.enable(:schema_linting))
  2. Go to the Pipeline Editor (CI/CD > Editor)
  3. If you type stage into the editor, it should no longer prompt a default "stage" value. It should show the error if the user doesn't provide a value.
  4. Typing an incorrect start_in value will show the updated description on hover.

Sample .gitlab-ci.yml content:

stages:
  - build

job:
  stage: build
  when: delayed
  start_in: 1 week
  script:
    echo "Hello World!"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mireya Andres

Merge request reports