Skip to content

Add ErrorHandling for Network Errors on Secure-Config Page

Jannik Lehmann requested to merge jnnkl-sec-config-graphql-error into master

What does this MR do and why?

This MR solves: #342912 (closed)

On the security-Configuration Page: when the enabled via Merge Request Button was clicked, and a Network or Backend error occurred. The page currently fails silently leaving our Users hanging without any information about what's been going wrong.

This MR changes that, it introduces a sticky Alert displaying the corresponding Error Message to the user interaction that has gone wrong.

Demo

before after
trim-before after-config-trim

How to reproduce

  1. Go to a project's Security & Compliance Configuration Page
  2. Find one where the BE throws an Error or, just throw the Error from L66 in L46
  3. Click the Configure via Merge Request Button
  4. see the error alert on the page

UX Concerns:

We didn't have designs for the particular error, the closest we got was this from this design Issue.

I'm not 100% happy with the current state of the UI. The sticky alert is necessary so that we avoid the case where a user is clicking a button at the bottom of the page and we show an error at the very top, which the user might never see.

What I think would be a more elegant way to solve this would be to have some kind of Error Message within the corresponding feature tile, that would also solve the problem that there now could be scenarios where it seems unclear to which of the scanners the error on top of the page is referring to.

I think the current state of this MR is still valid first iteration since it gives a benefit to our users.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports