Skip to content

Fixed remaining cop offenses for Naming/FileName

What does this MR do and why?

Describe in detail what your merge request does and why.

  1. In all the mentioned files added # rubocop:enable Naming/FileName and # rubocop:disable Naming/FileName
  2. Renamed one file from (tooling/lib/tooling/images.rb) to (tooling/lib/tooling/image.rb)
  3. Added multiple acronyms in the list
    • CSP
    • CSV
    • Branch
    • SCA
    • SAN
    • CIDR
    • SPDX
    • Object
    • JavaScript
    • MR
    • SSE
    • Gitlab
    • JWT
    • HLL
    • AST
    • VS
    • GPG
    • ECDSA
    • ED25519
    • OTP
    • GID
    • AR
    • Image
    • RSpec

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

CSP         --> gitlab\app\controllers\concerns\clientside_preview_csp.rb
CSV         --> gitlab\app\models\blob_viewer\csv.rb
Branch      --> gitlab\ee\app\models\dast\branch.rb
SCA         --> gitlab\ee\app\models\sca.rb
SAN         --> gitlab\ee\lib\gitlab\auth\smartcard\san_extension.rb
CIDR        --> gitlab\ee\lib\gitlab\cidr.rb
Bool        --> gitlab\ee\lib\gitlab\elastic\bool_expr.rb
SPDX        --> gitlab\ee\lib\gitlab\spdx\catalogue_gateway.rb
Object      --> gitlab\ee\lib\gitlab\status_page\storage\object.rb
JavaScript  --> gitlab\haml_lint\inline_javascript.rb
MR          --> gitlab\lib\api\entities\mr_note.rb
SSE         --> gitlab\lib\api\helpers\sse_helpers.rb
Gitlab      --> gitlab\lib\gitlab\database\migrations\observation.rb
JWT         --> gitlab\lib\gitlab\jwt_token.rb
HLL         --> gitlab\lib\gitlab\redis\hll.rb
AST         --> gitlab\lib\gitlab\template_parser\ast.rb
VS          --> gitlab\lib\gitlab\usage_data_counters\vs_code_extension_activity_unique_counter.rb
GPG         --> gitlab\qa\qa\resource\user_gpg.rb
ECDSA       --> gitlab\qa\qa\runtime\key\ecdsa.rb
ED25519     --> gitlab\qa\qa\runtime\key\ed25519.rb
OTP         --> gitlab\qa\qa\support\otp.rb
GID         --> gitlab\rubocop\cop\graphql\gid_expected_type.rb
AR          --> gitlab\rubocop\cop\performance\ar_count_each.rb
Image       --> gitlab\tooling\lib\tooling\image.rb
RSpec       --> gitlab\tooling\lib\tooling\parallel_rspec_runner.rb

Contributes to #343244 (closed).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by yhgupta

Merge request reports