Move Security ConfigurationPresenter to FOSS
What does this MR do and why?
As SAST and SecretDetection features are moved to GitLab Free, we need to migrate some parts of the codebase to FOSS. This MR move ConfigurationPresenter and related code. That enables us to create proper security configuration for GitLab Free users.
Screenshots or screen recordings
This MR doesn't change the user-faced logic of the application
How to set up and validate locally
- On a GitLab instance with an Ultimate license,
- Create a project, go to the Security -> Configuration page.
- Observe that everything works correctly.
At the moment, we don't use ConfigurationPresenter for GitLab Free.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #342135 (closed)
Merge request reports
Activity
changed milestone to %14.5
added Category:Vulnerability Management Deliverable Enterprise Edition GitLab Core GitLab Free GitLab Premium GitLab Ultimate backend devopssecure groupcomposition analysis maintenancerefactor missed-deliverable missed:14.4 pipeline:run-all-rspec pipeline:run-as-if-foss quad-planningcomplete-no-action sectionsec typefeature typemaintenance workflowin dev + 1 deleted label
assigned to @brytannia
1 Warning This merge request is quite big (987 lines changed), please consider splitting it into multiple merge requests. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Mark Fletcher ( @markglenfletcher
) (UTC+0, 3 hours behind@brytannia
)Vasilii Iakliushin ( @vyaklushin
) (UTC+1, 2 hours behind@brytannia
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report for 8f531bbb!review-qa-smoke:
test reportadded 2 commits
added 994 commits
-
4ce8d2d1...7d567806 - 986 commits from branch
master
- 7fd061aa - Create FOSS presenter
- 96449275 - Add FOSS test
- 38064af4 - Move concern to FOSS
- 1f083878 - Add frozen string literal
- e7797835 - Divide tests by GitLab instance
- e857cfbd - Move Scan presenter to separate entity
- 08577d1d - Remove scan tests from presenter tests
- 22cd65b4 - Remove tests duplicates
Toggle commit list-
4ce8d2d1...7d567806 - 986 commits from branch
removed typefeature label
mentioned in issue #339023 (closed)
added 629 commits
-
7a1a469a...4a4b80a6 - 619 commits from branch
master
- aa0e0bfa - Create FOSS presenter
- fc6e0e73 - Add FOSS test
- f60aaee6 - Move concern to FOSS
- c7e11e39 - Add frozen string literal
- 24d62138 - Divide tests by GitLab instance
- 7209d042 - Move Scan presenter to separate entity
- 6a0970e3 - Remove scan tests from presenter tests
- 68bbc23a - Remove tests duplicates
- f2c5c457 - Fix tests by spliting Scan presenter
- 54741650 - Convert ScanConfiguration to PORO
Toggle commit list-
7a1a469a...4a4b80a6 - 619 commits from branch
added 2 commits
mentioned in merge request !73464 (merged)
mentioned in merge request !73467 (merged)
added 514 commits
-
2abb083e...e761acdf - 502 commits from branch
master
- d48d0000 - Create FOSS presenter
- 0baac5b2 - Add FOSS test
- 7c103acd - Move concern to FOSS
- 8cb2d65a - Add frozen string literal
- 13c70be3 - Divide tests by GitLab instance
- 62052c2e - Move Scan presenter to separate entity
- d7f83b6c - Remove scan tests from presenter tests
- 24c70b9b - Remove tests duplicates
- eb554b4a - Fix tests by spliting Scan presenter
- f1879180 - Convert ScanConfiguration to PORO
- 6a364a53 - Remove unused class
- aa1561e3 - Fix object lookup chain
Toggle commit list-
2abb083e...e761acdf - 502 commits from branch
added 1 commit
- 98e36ff8 - Move Security ConfigurationPresenter to FOSS
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @theoretick
- Resolved by Lucas Charles
@theoretick could you please review this MR?
that's related to the other two MRs that you have reviewed.
added 1 commit
- 796bceb5 - Move Security ConfigurationPresenter to FOSS
- Resolved by Lucas Charles
- Resolved by Tetiana Chupryna
- Resolved by Tetiana Chupryna
- Resolved by Tetiana Chupryna
removed review request for @theoretick
@theoretick
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @theoretick
- Resolved by Tetiana Chupryna
removed review request for @theoretick
- Resolved by Matthias Käppler
@mkaeppler could you please review this MR?
I'd love to hear your opinion about this solution and your suggestions
requested review from @mkaeppler
- Resolved by Matthias Käppler
- Resolved by Matthias Käppler
@brytannia it looks like there are merge conflicts now; could you have a look?
added 1287 commits
Toggle commit listenabled an automatic merge when the pipeline for 852198c4 succeeds
mentioned in commit 49da15c8
added workflowstaging-canary label and removed workflowin dev label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #345724 (closed)
mentioned in commit b36f555f
mentioned in merge request !74537 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !75472 (merged)