Skip to content
Snippets Groups Projects

Move Security ConfigurationPresenter to FOSS

Merged Tetiana Chupryna requested to merge 342135-move-presenters into master
All threads resolved!

What does this MR do and why?

As SAST and SecretDetection features are moved to GitLab Free, we need to migrate some parts of the codebase to FOSS. This MR move ConfigurationPresenter and related code. That enables us to create proper security configuration for GitLab Free users.

Screenshots or screen recordings

This MR doesn't change the user-faced logic of the application

How to set up and validate locally

  1. On a GitLab instance with an Ultimate license,
  2. Create a project, go to the Security -> Configuration page.
  3. Observe that everything works correctly.

At the moment, we don't use ConfigurationPresenter for GitLab Free.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #342135 (closed)

Edited by Tetiana Chupryna

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lucas Charles approved this merge request

    approved this merge request

  • Lucas Charles removed review request for @theoretick

    removed review request for @theoretick

  • :wave: @theoretick, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • added 1 commit

    Compare with previous version

  • requested review from @theoretick

  • Lucas Charles resolved all threads

    resolved all threads

  • Lucas Charles removed review request for @theoretick

    removed review request for @theoretick

  • Tetiana Chupryna resolved all threads

    resolved all threads

  • added 1 commit

    • 1af1fefe - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Tetiana Chupryna requested review from @mkaeppler

    requested review from @mkaeppler

  • Matthias Käppler
  • Matthias Käppler approved this merge request

    approved this merge request

  • added 1 commit

    Compare with previous version

  • Matthias Käppler resolved all threads

    resolved all threads

  • Tetiana Chupryna added 1287 commits

    added 1287 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Matthias Käppler resolved all threads

    resolved all threads

  • Matthias Käppler enabled an automatic merge when the pipeline for 852198c4 succeeds

    enabled an automatic merge when the pipeline for 852198c4 succeeds

  • mentioned in commit 49da15c8

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in commit b36f555f

  • mentioned in merge request !74537 (merged)

  • Tetiana Chupryna mentioned in merge request !75472 (merged)

    mentioned in merge request !75472 (merged)

  • Please register or sign in to reply
    Loading