Draft: Exclude Security Incidents from Operations Incidents page
What does this MR do and why?
This change removes security incidents from Operations -> Incidents page to make sure we will show only relevant alerts for Operations.
Screenshots or screen recordings
TBD
How to set up and validate locally
- Create new project.
- Add Kubernetes cluster for the project (GKE).
- Using Cluster Management Project (https://docs.gitlab.com/ee/user/clusters/management_project_template.html) install Prometheus and Cilium.
- Add some Network Policies that will be captured.
- Ensure Operations Incidents are properly showing up in https://your.gitlab/YOUR-GROUP/YOUR-PROJECT/-/incidents, but Security incidents are not visible.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #323276 (closed)
Merge request reports
Activity
changed milestone to %14.5
assigned to @mparuszewski
2 Warnings 47654a20: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Josianne Hyson ( @jhyson
) (UTC+13, 11 hours ahead of@mparuszewski
)Matthias Käppler ( @mkaeppler
) (UTC+2, same timezone as@mparuszewski
)frontend Alexander Turinske ( @aturinske
) (UTC-6, 8 hours behind@mparuszewski
)Vitaly Slobodin ( @vitallium
) (UTC+3, 1 hour ahead of@mparuszewski
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits cdff3a38 and 47654a20
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.24 MB 3.24 MB - 0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 %
Note: We do not have exact data for cdff3a38. So we have used data from: 21388c5b.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 47654a20!review-qa-smoke:
test reportremoved [deprecated] Accepting merge requests label