Enable linear GroupTree ancestors queries
What does this MR do and why?
In this MR we're removing the feature flag linear_group_tree_ancestor_scopes
to allow linear GrouPTree ancestor queries.
How to set up and validate locally
- Go to the page
http://127.0.0.1:3000/dashboard/groups
- Set a filter in the group search box:
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #341117 (closed)
Merge request reports
Activity
changed milestone to %14.5
assigned to @fjsanpedro
1 Warning Please add a merge request type to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Hordur Freyr Yngvason ( @hfyngvason
) (UTC-4, 6 hours behind@fjsanpedro
)Bob Van Landuyt ( @reprazent
) (UTC+2, same timezone as@fjsanpedro
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger @fjsanpedro, please can you answer the question: Should this have a feature flag? to help with code review for the Access group.This nudge was added by this triage-ops policy.
added 161 commits
-
1a81c463...df9eb2d6 - 160 commits from branch
master
- f74200e4 - Enable linear GroupTree ancestors queries
-
1a81c463...df9eb2d6 - 160 commits from branch
added 167 commits
-
f74200e4...77eb6faa - 166 commits from branch
master
- b96b024d - Enable linear GroupTree ancestors queries
-
f74200e4...77eb6faa - 166 commits from branch
- Resolved by Dylan Griffith
@alexpooley can you review this MR?
requested review from @alexpooley
added 228 commits
-
b96b024d...dbe47283 - 227 commits from branch
master
- 0608bbe4 - Enable linear GroupTree ancestors queries
-
b96b024d...dbe47283 - 227 commits from branch
added 140 commits
-
0608bbe4...c1c86848 - 139 commits from branch
master
- 458273d0 - Enable linear GroupTree ancestors queries
-
0608bbe4...c1c86848 - 139 commits from branch
added 170 commits
-
458273d0...8f2b5432 - 169 commits from branch
master
- 75952ddd - Enable linear GroupTree ancestors queries
-
458273d0...8f2b5432 - 169 commits from branch
requested review from @DylanGriffith
@alexpooley
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 152 commits
-
75952ddd...e68a508e - 151 commits from branch
master
- a532cfbd - Enable linear GroupTree ancestors queries
-
75952ddd...e68a508e - 151 commits from branch
enabled an automatic merge when the pipeline for 0450f71a succeeds
mentioned in commit e28bf200
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in epic &6738 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!388 (merged)