Skip to content

Deprecate fullPath from DAST on-demand mutations

Philip Cunningham requested to merge philipcunningham-find-by-global-id-321205 into master

What does this MR do and why?

deprecates and marks fullPath arguments as no longer required in mulitple dast mutations. since we're passing global ids to these mutation, we shouldn't need to also pass a fullPath in order to qualify them.

Related Issue(s)

Deprecate full_path from DAST mutations in favour of finding/authorising by GlobalID

Screenshots

Delete

delete

Update

example

Run

example

Testing

  1. seed your local development environment
bundle exec rake db:seed_fu FILTER=dast_profiles

  1. navigate to a project of your choice and visit /-/security/configuration/dast_scans#saved-scans

  2. attempt to delete/run a scan

  3. attempt delete/update a site profile

  4. attempt to delete/update a scanner profile

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Philip Cunningham

Merge request reports