WIP: Grammar correction (project-wide): "set up" and "setup" are different (in text, not code)
What does this MR do?
This MR corrects the grammar of "set up" and "setup" across the entire project: documentation, code comments, views, etc. It does not touch any actual code (I hope), except for strings that are visible to users. Setup and set up are used very inconsistently, sometimes right and sometimes wrong. I probably missed a few, but I think this corrects the vast majority of the issues.
My only problem is that I'm not sure why the tests fail on the gitlab.pot (internationalisation) file. I manually updated locale/gitlab.pot because bin/rake gettext:regenerate
doesn't work (I don't have databases set up, just a fork of the repository), but that doesn't work either. What do I need to do to pass the failed test?
Grammar Explanation
Setup is a noun or adjective, while set up is a verb. An easy way to think about it is to replace them with configuration or configure, so setup = configuration(noun/adjective), and set up = configure(verb).
Examples from GitLab itself (with images below, red boxes = incorrect, green boxes = correct):
Does this MR meet the acceptance criteria?
-
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides