Skip to content

Migrate historical_max_users metric to Instrumentation class

Niko Belokolodov requested to merge 338461-migrate-subscription-metrics-to-use-instrumentation-classes into master

What does this MR do and why?

Related to #338461 (closed)

Migrate historical_max_users EE metric to Instrumentation class.

How to set up and validate locally

Covered by an unit test https://gitlab.com/gitlab-org/gitlab/blob/f272c7dd5ea10394c4d2dd2f90a249dd35964632/ee/spec/lib/ee/gitlab/usage_data_spec.rb#L205-205

To test manually:

  1. Gitlab::UsageDataNonSqlMetrics.uncached_data['historical_max_users'] for usage data
  2. ServicePing::SubmitService.new.execute then check at RawUsageData.last.payload['historical_max_users'] for service ping

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #338461 (closed)

Edited by Niko Belokolodov

Merge request reports