Skip to content

Fix undefined method performed_write? error in GDK

Hordur Freyr Yngvason requested to merge fix-another-load-balancing-sticking-autoload-issue into master

What does this MR do and why?

Fixes an autoloading issue similar to the one resolved in !72247 (merged)

Screenshots or screen recordings

N/A. I patched this locally to unblock myself and haven't been able to reproduce. Another developer reported the following stacktrace:

NoMethodError - undefined method `performed_write?' for nil:NilClass:
  lib/gitlab/metrics/rack_middleware.rb:16:in `block in call'
  lib/gitlab/metrics/web_transaction.rb:21:in `run'
  lib/gitlab/metrics/rack_middleware.rb:16:in `call'
  lib/gitlab/jira/middleware.rb:19:in `call'
  lib/gitlab/middleware/go.rb:20:in `call'
  lib/gitlab/etag_caching/middleware.rb:21:in `call'

How to set up and validate locally

The bug presents itself randomly. Don't know how to reproduce.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Hordur Freyr Yngvason

Merge request reports