Skip to content

Convert terms of service to Vue and add max height

What does this MR do and why?

Related to #22139 (closed)

Converts the terms of service to Vue and requires user to scroll to the bottom before Accept button becomes enabled.

Screenshots or screen recordings

Before After
Untitled__2_ Untitled__1_
TOS longer than page TOS shorter than page
Screen_Shot_2021-10-18_at_1.29.57_PM Screen_Shot_2021-10-18_at_1.30.53_PM

How to set up and validate locally

  1. Enable the terms_of_service_vue feature flag.
    • bin/rails console
    • Feature.enable(:terms_of_service_vue)
  2. Login as an admin (root user in GDK).
  3. Navigate to /admin/application_settings/general.
  4. In the Terms of Service and Privacy Policy panel check the All users must accept the Terms of Service and Privacy Policy to access GitLab checkbox and enter some text in the text area. Save the form.
  5. Navigate to /admin/users and choose a user.
  6. Click Impersonate in the upper right corner.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports