Replace calls to LoadBalancing with ::Gitlab::Database::LoadBalancing
What does this MR do and why?
Replaces a call to LoadBalancing
in rack middleware with ::Gitlab::Database::LoadBalancing
.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.4
assigned to @mwoolf
added backend database devopsmanage groupcompliance labels
- A deleted user
added databasereview pending label
2 Warnings Please add a merge request type to this merge request. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alexandru Croitor ( @acroitor
) (UTC+3, 2 hours ahead of@mwoolf
)Doug Stull ( @dstull
) (UTC-4, 5 hours behind@mwoolf
)database Simon Tomlinson ( @stomlinson
) (UTC-5, 6 hours behind@mwoolf
)Adam Hegyi ( @ahegyi
) (UTC+2, 1 hour ahead of@mwoolf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed databasereview pending label
- Resolved by Adam Hegyi
@dskim_gitlab Could you do the database review please? This is causing issues with GDK in development right now.
@engwan Since you suggested the fix, could you do the backend review and we'll hand it to a different maintainer after that.
requested review from @dskim_gitlab and @engwan
@dstull Over to you for maintainer review please
removed review request for @engwan
@engwan
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- A deleted user
added databasereview pending label
added databasereviewed label and removed databasereview pending label
requested review from @ahegyi and removed review request for @dskim_gitlab
added sectiondev label
added 165 commits
-
5bc1ac74...63bf35e0 - 164 commits from branch
master
- d54189d0 - Replace calls to LoadBalancing with ::Gitlab::Database::LoadBalancing
-
5bc1ac74...63bf35e0 - 164 commits from branch
added databaseapproved label and removed databasereviewed label
enabled an automatic merge when the pipeline for 8b2a2547 succeeds
mentioned in commit 105179f7
requested review from @dstull
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
removed review request for @dstull
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!306 (merged)
added releasedpublished label and removed releasedcandidate label