Skip to content

Use unique key for generating row numbers

Jacques Erasmus requested to merge 337226-lazy-load-commits-unique-key into master

What does this MR do and why?

In !71633 (merged) we added the ability to lazy load commit data.

This fixes a bug where duplicate row numbers that can cause orphaned commit entries are generated in some cases.

Screenshots or screen recordings

before after
commit for last entry not loading all commits loaded
Screenshot_2021-10-12_at_09.48.34 Screenshot_2021-10-12_at_09.49.09

How to set up and validate locally

Example below:

  1. Enable the lazy load feature flag

    Feature.enable(:lazy_load_commits)
  2. Open a repo with exactly 101 entries

  3. All commits should load

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #337226 (closed)

Edited by Jacques Erasmus

Merge request reports