Skip to content

Fixing gitaly backend node recovery tests

Description of the test

Fixes #322647 (closed)

Test Case: gitlab-org/quality/testcases#978 (closed)

The majority of the fixes for this issue already occurred in !71789 (merged) so the changes required to fix this issue were minimal.

The flow of the test is

  1. Stop gitaly1
  2. Publish a commit to either gitaly2/gitaly3 (a primary is automatically determined by an election)
  3. Restart gitaly1 (in the background allow replication to occur)
  4. Stop gitaly2/gitaly3
  5. Query the project's commit history which can now only be served by gitaly1, thus validating the data was synced at stop 3

Check-list

  • Confirm the test has a testcase: tag linking to an existing test case in the test case project.
  • Note if the test is intended to run in specific scenarios. If a scenario is new, add a link to the MR that adds the new scenario.
  • Follow the end-to-end tests style guide and best practices.
  • Use the appropriate RSpec metadata tag(s).
  • Ensure that a created resource is removed after test execution. A Group resource can be shared between multiple tests. Do not remove it unless it has a unique path. Note that we have a cleanup job that periodically removes groups under gitlab-qa-sandbox-group.
  • Ensure that no transient bugs are hidden accidentally due to the usage of waits and reloads.
  • Verify the tags to ensure it runs on the desired test environments.
  • If this MR has a dependency on another MR, such as a GitLab QA MR, specify the order in which the MRs should be merged.
  • (If applicable) Create a follow-up issue to document the special setup necessary to run the test: ISSUE_LINK
  • If the test requires an admin's personal access token, ensure that the test passes on your local with and without the GITLAB_QA_ADMIN_ACCESS_TOKEN provided.
Edited by John McDonnell

Merge request reports

Loading