Skip to content

Fix spacing around code quality problem icon in diff view

Anton Kalodzich requested to merge antonykor.ak/gitlab:bugfix/342671-code-quality-icon into master

What does this MR do and why?

Currently code quality problem icon in diff is under the plus sign and because of it popover is not displayed on hover

This MR changes selector for row in diff of file with quality problems according to !68528 (diffs)

Screenshots or screen recordings

Before: Add_long_if_statement_to_code___1____Merge_requests___Seth_Berger___code-quality-annotation-demo___GitLab

After: image

How to set up and validate locally

  1. Open Merge Request with quality problems (like sethgitlab/code-quality-annotation-demo!1 (diffs)) in EE
  2. Open 'Changes'
  3. Open diff of file with quality problems

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Solves #342671 (closed)

Edited by Anton Kalodzich

Merge request reports