Skip to content

Fixes rendering duplicate data-src attribute

Tim Zallmann requested to merge tz-fix-double-data-src into master

What does this MR do and why?

We are currently rendering on the issue list the assignee avatars with duplicate data-src attributes. (Only visible lookin at the source HTML as it is then replaced by JS). This also showed up in HTML errors as malformed HTML + duplicate information. Same base HAML template is also used on the Merge Request List.

<li class="gl-display-flex">
<a class="author-link has-tooltip" title="Assigned to Administrator" data-container="body" data-qa-selector="assignee_link" href="/root"><img width="16" class="avatar avatar-inline s16 lazy" alt="" data-src="/uploads/-/system/user/avatar/1/avatar.png?width=16" data-src="/uploads/-/system/user/avatar/1/avatar.png?width=16" src="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" /></a>
</li>

After:

<li class="gl-display-flex">
<a class="author-link has-tooltip" title="Assigned to Administrator" data-container="body" data-qa-selector="assignee_link" href="/root"><img width="16" class="avatar avatar-inline s16 lazy" alt="" data-src="/uploads/-/system/user/avatar/1/avatar.png?width=16" src="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" /></a>
</li>

Screenshots or screen recordings

Bildschirmfoto_2021-10-11_um_16.49.56

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tim Zallmann

Merge request reports