Default enable use_upsert_query_for_mr_metrics FF
What does this MR do and why?
This MR enables the use_upsert_query_for_mr_metrics
feature flag by default. The flag is already enabled globally on PRD since 14.3.
Rollout issue: #339677 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.4
added typemaintenance label
assigned to @ahegyi
added typefeature label
- A deleted user
added feature flag label
- Resolved by Adam Hegyi
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alex Buijs ( @alexbuijs
) (UTC+2, same timezone as@ahegyi
)Bob Van Landuyt ( @reprazent
) (UTC+2, same timezone as@ahegyi
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 37723ac4 - Default enable use_upsert_query_for_mr_metrics FF
- A deleted user
added backend label
Hi, @engwan! Could you do the BE maintainer review?
requested review from @engwan
mentioned in commit 73eda3ea
@engwan
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!306 (merged)
removed typefeature label
added releasedpublished label and removed releasedcandidate label