Skip to content
Snippets Groups Projects

Default enable use_upsert_query_for_mr_metrics FF

Merged Adam Hegyi requested to merge default_enable_use_upsert_query_for_mr_metrics into master
All threads resolved!

What does this MR do and why?

This MR enables the use_upsert_query_for_mr_metrics feature flag by default. The flag is already enabled globally on PRD since 14.3.

Rollout issue: #339677 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Adam Hegyi

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1 Warning
    :warning: You've made some app changes, but didn't add any tests.
    That's OK as long as you're refactoring existing code,
    but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Alex Buijs (@alexbuijs) (UTC+2, same timezone as @ahegyi) Bob Van Landuyt (@reprazent) (UTC+2, same timezone as @ahegyi)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Adam Hegyi added 1 commit

    added 1 commit

    • 37723ac4 - Default enable use_upsert_query_for_mr_metrics FF

    Compare with previous version

  • A deleted user added backend label

    added backend label

  • Adam Hegyi resolved all threads

    resolved all threads

  • Author Maintainer

    Hi, @engwan! Could you do the BE maintainer review?

  • Adam Hegyi requested review from @engwan

    requested review from @engwan

  • Adam Hegyi changed the description

    changed the description

  • Heinrich Lee Yu approved this merge request

    approved this merge request

  • Looks good to me :thumbsup:

  • Heinrich Lee Yu mentioned in commit 73eda3ea

    mentioned in commit 73eda3ea

  • :wave: @engwan, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading