DevOps Adoption - Remove data-testid constants
What does this MR do and why?
Removes the exported test ids in order to make it easier to strip test-ids from production at a later stage.
Screenshots or screen recordings
n/a
How to set up and validate locally
yarn jest ee/spec/frontend/analytics/devops_report/devops_adoption/
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #339452 (closed)
Merge request reports
Activity
changed milestone to %14.4
assigned to @blabuschagne
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed workflowready for development label
1 Warning e05b3cf7: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Himanshu Kapoor ( @himkp
) (UTC+2, same timezone as@blabuschagne
)Nicolò Maria Mezzopera ( @nmezzopera
) (UTC+2, same timezone as@blabuschagne
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@nmezzopera I'm skipping the initial review here as this is a small tech debt fix, hope that's okay
requested review from @nmezzopera
Allure report
allure-report-publisher
generated test report for e05b3cf7!review-qa-smoke:
test reportmentioned in commit b247b888
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
removed typefeature label
added releasedpublished label and removed releasedcandidate label