Skip to content

Set gitlab_schema for Doorkeeper::Application

Dylan Griffith requested to merge fix-doorkeeper-cross-db-modification-error into master

What does this MR do and why?

These models are defined in the doorkeeper gem and correspond to the oauth_applications, oauth_access_grants and oauth_access_tokens tables in our database. There is also a model defined in the doorkeeper-openid_connect gem which corresponds to the oauth_openid_requests table.

This change is necessary to avoid CrossDatabaseModificationAcrossUnsupportedTablesError errors. We use this gitlab_schema metadata to determine which database these tables are meant to belong in so that we can raise exceptions in specs if you try to join between tables that are going to be split onto different databases. Since we don't plan to move these to the CI database they should be marked as gitlab_main.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dylan Griffith

Merge request reports