Add policy name to ScanExecutionPolicyCommit mutation
What does this MR do and why?
Addresses #342695 (closed)
This MR adds policy name to ScanExecutionPolicyCommit
mutation which was introduced in !71655 (merged)
Screenshots or screen recordings
How to set up and validate locally
- Go to
Security & Compliance
->Policies
- Create a new policy by clicking
New Policy
- Give a name for the policy and click
Create Merge Request
and merge the created MR - Go to
Policies
and edit the newly created policy and update the name of the policy
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.5
assigned to @sashi_kumar
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Tristan Read ( @tristan.read
) (UTC+13, 7.5 hours ahead of@sashi_kumar
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, same timezone as@sashi_kumar
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report for 35a53cae!review-qa-smoke:
test report- Resolved by Sashi Kumar Kumaresan
added 1545 commits
-
9b10aace...fd0d60b8 - 1544 commits from branch
master
- b5c992b9 - Add policy name to ScanExecutionPolicyCommit mutation
-
9b10aace...fd0d60b8 - 1544 commits from branch
changed milestone to %14.6
mentioned in issue #339794 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b2c40a05 and 35a53cae
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.24 MB 3.24 MB - -0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 % Significant Reduction: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.environments.index 1.28 MB 1.25 MB -29.49 KB -2.3 %
Note: We do not have exact data for b2c40a05. So we have used data from: 1f52a43b.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1620 commits
-
b5c992b9...5f0c22c2 - 1619 commits from branch
master
- 35a53cae - Add policy name to ScanExecutionPolicyCommit mutation
-
b5c992b9...5f0c22c2 - 1619 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Ezekiel Kigbo
@aturinske Could you please do the initial review?
requested review from @aturinske
requested review from @ekigbo and removed review request for @aturinske
@aturinske
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
changed milestone to %14.5
enabled an automatic merge when the pipeline for e55cc9f2 succeeds
mentioned in commit fb95828f
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!388 (merged)