Skip to content

Add missing labels for token fields of Github and ZenTao integrations

Luke Duncalfe requested to merge ld-add-non_empty_password_help-properties-to-integrations into master

What does this MR do and why?

This MR adds titles and labels to the token fields of Github and ZenTao integrations, which display when viewing the form of the integrations once they have been saved.

The labels tell the user that they can leave the field blank to continue using the current token.

This is similar to other integrations that have a type: 'password' field, like BambooHR, Jira, and Jenkins. The existing frontend integration form will display these labels when they're supplied by the backend.

Screenshots or screen recordings

github

zentao

How to set up and validate locally

To QA the GitHub integration:

  1. Visit the GitHub integration form for a project http://127.0.0.1:3000/<project full path>/-/services/github/edit.
  2. Enter mytoken for the token, and https://github.com/example for the repository URL.
  3. Save the integration
  4. View the integration form again. The token field will have the placeholder text and you should see a label below the token field: "Leave blank to use your current token"

To QA the Zentao integration:

  1. Enable the zentao_issues_integration feature flag.
  2. Visit the Zentao integration form for a project http://127.0.0.1:3000/<project full path>/-/services/zentao/edit.
  3. For "web URL", enter https://www.zentao.net, enter mytoken for the token, and product for the Product ID.
  4. Save the integration
  5. View the integration form again. The token field will have the placeholder text and you should see a label below the token field: "Leave blank to use your current token"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Markus Koller

Merge request reports