Skip to content

No-op BuildFinishedWorker for deleted and pending_delete projects

drew stachon requested to merge noop-build-finished-for-deleted-projects into master

What does this MR do and why?

This merge request prevents us from running the normal operations of BuildFinishedWorker if a Projects is deleted or is pending_delete set to true, that is, in the process of being deleted.

The callback for counting CI minutes is on EE::Ci::Build, so we'll continue to do that. But none of the operations in BuildFinishedWorker make sense when the whole Project is being thrown away.

This is a performance and error-prevention improvement being made prior to !71342 (comment 691526743), as part of https://gitlab.com/gitlab-org/gitlab/-/issues/24644

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by drew stachon

Merge request reports