Skip to content

Fix sidebar navigation dropdown header to be theme neutral

Olena Horal-Koretska requested to merge Make-sidebar-nav-headers-theme-dependent into master

What does this MR do and why?

EDIT:

Updates sidebar collapsed fly out header color to be theme agnostic (based on this comment).

ORIGINAL:

Updates sidebar header color to the theme color (matching the header). Raised here

Screenshots or screen recordings

EDIT:

Description Before After
Dark mode Screen_Shot_2021-10-07_at_8.44.42_PM Screen_Shot_2021-10-07_at_6.28.05_PM
Red Screen_Shot_2021-10-07_at_8.48.21_PM Screen_Shot_2021-10-07_at_6.28.26_PM
Light Screen_Shot_2021-10-07_at_8.48.37_PM Screen_Shot_2021-10-07_at_6.28.44_PM
Indigo Screen_Shot_2021-10-07_at_8.42.15_PM Screen_Shot_2021-10-07_at_6.29.10_PM

ORIGINAL:

Before After
Screenshot_2021-10-07_at_16.49.25 Screenshot_2021-10-07_at_16.46.15
Screenshot_2021-10-07_at_16.48.59 Screenshot_2021-10-07_at_16.46.45
Screenshot_2021-10-07_at_16.49.44 Screenshot_2021-10-07_at_16.47.10

How to set up and validate locally

  1. Collapse the sidebar
  2. Hover over a menu item with subitems
  3. Notice the color of the submenu header => it should be theme agnostic
  4. Try the same steps for different themes (Update under profile/preferences).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Paul Slaughter

Merge request reports