Skip to content

Delete dead global JS code

Coung Ngo requested to merge cngo-delete-dead-code into master

What does this MR do and why?

This MR deletes dead global JS code.

In app/assets/javascripts/behaviors/requires_input.js, all form.js-requires-input elements are selected then a function hideOrShowHelpBlock is called for each of these elements.

hideOrShowHelpBlock selects .js-select-namespace, which only exists in the following files:

  • app/views/projects/_new_project_fields.html.haml
  • app/views/import/manifest/_form.html.haml
  • app/views/import/shared/_new_project_form.html.haml

These files correspond to the following pages:

  • /projects/new#blank_project
  • /import/manifest/new
  • /import/phabricator/new

These pages don't contain the class .js-requires-input, so the hideOrShowHelpBlock function doesn't do anything and is therefore deleted in this MR.

Screenshots or screen recordings

How to set up and validate locally

  • Checkout master branch
  • Visit the following pages and confirm they don't contain a .js-requires-input class, and therefore the code in this MR can be deleted
    • /projects/new#blank_project
    • /import/manifest/new
    • /import/phabricator/new

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports