Skip to content

Draft: POC Load linked notes diff file

Phil Hughes requested to merge ph/224159/pocLoadNoteDiffFile into master

What does this MR do and why?

DO NOTE MERGE!!!!

This is a proof of concept to allow our diffs app to instantly load a specific linked to file via a diff note. To make this work for now I have changed the note hash URL to include what page to load, though we will need to find a better way to do this.

What benefits do we get with this?

Locally I was seeing the below numbers. These numbers are gathered by linking to a file on the 19th file, which I think would be around the 3rd/4th diff batchs request.

Before After
~8s ~2s

Screenshots or screen recordings

Screen_Recording_2021-10-19_at_16.18.01_720

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Moreira da Silva

Merge request reports