Skip to content

Create partial for webhook deliveries table

Tom Quirk requested to merge 335128-consolidate-webhook-deliveries-table into master

What does this MR do and why?

In preparation for some UI polish !71788 (merged), this MR adds a partial for the Recent deliveries table. The Admin and Project-level web hook templates have been updated to use this partial in place of their existing tables.

Screenshots or screen recordings

Screenshots demonstrate no change + fixes for mobile.

Admin-level

/admin/hooks/:id/edit

Before After
Screen_Shot_2021-10-06_at_2.42.55_pm Screen_Shot_2021-10-06_at_2.37.03_pm
Screen_Shot_2021-10-06_at_2.41.42_pm Screen_Shot_2021-10-06_at_2.47.56_pm

Project-level

/:project/-/hooks/:id/edit

Before After
Screen_Shot_2021-10-06_at_2.43.40_pm Screen_Shot_2021-10-06_at_2.45.45_pm
Screen_Shot_2021-10-06_at_2.44.14_pm Screen_Shot_2021-10-06_at_2.46.11_pm

How to set up and validate locally

To generate an entry in the "Recent deliveries" table:

Project level:

  1. Navigate to a project's Settings > Webhooks.
  2. Create a mock webhook (any URL is fine). The new webhook should appear in the table below the form.
  3. Click Edit on the webhook
  4. Click Test, and wait for the test to finish
  5. Refresh the page.

The failed webhook entry should be visible in the table.

Admin level:

Same as above, but navigate to System Hooks from the admin dashboard.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #335128 (closed)

Edited by Tom Quirk

Merge request reports