Skip to content

Break up cross-model Security::Scan/Finding scope

drew stachon requested to merge improve-security-scopes into master

What does this MR do and why?

This MR makes a few improvements that were non-blocking recommendations in !71614 (merged).

  1. Breaks up the join scope in Security::Finding into two scopes. The second scope is now in Security::Scan and is merged into the Security::Finding scope that we just updated.
  2. Adds a with_cross_joins_prevented scope to ensure that we continue to prevent these joins with no future regressions.

How to set up and validate locally

The modified spec here ensures that the behavior of the scope in Security::Finding has not changed.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports