Remove sync_namespace_name_with_cdot flag
What does this MR do and why?
Feature Flag Rollout Issue: #341056 (closed)
Issue that introduced the flag: !69896 (merged)
ADDITIONAL CONTEXT
The sync_namespace_name_with_cdot
feature flag was introduced as part of !69896 (merged) to allow for the code to avoid a multi-version compatibility issue.
This might happen when jobs get scheduled by a new Web worker (new code) but get picked up by an old Sidekiq worker (new code is not deployed there yet so it doesn't know about Namespaces::SyncNamespaceNameWorker
) resulting on errors.
Once the code is deployed everywhere, the flag is enabled and it works properly the flag is good to go.
Details for when the flag was enabled in production
Screenshots or screen recordings
Does not apply
How to set up and validate locally
Does not apply.
However if you want to double check the current functionality (optional as this was already tested):
- Go to a paid group in Gitlab.com
- Rename the group
- Go to CustomersDot -> Manage Subscriptions
- The group name should be up to date
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.4
added backend feature flag groupprovision sectionfulfillment typefeature labels
assigned to @vshumilo
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ethan Urie ( @eurie
) (UTC-4, 1 hour ahead of@vshumilo
)Sean McGivern ( @smcgivern
) (UTC+1, 6 hours ahead of@vshumilo
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @cwiesner
Setting label(s) ~"Category:License" devopsfulfillment based on grouplicense.
added devopsfulfillment + 1 deleted label
removed review request for @cwiesner
@cwiesner
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @mwoolf
enabled an automatic merge when the pipeline for 67f2e140 succeeds
mentioned in commit f23c3794
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!306 (merged)
added releasedpublished label and removed releasedcandidate label