Skip to content
Snippets Groups Projects

Don't run WAL queries when not using replicas

Merged Yorick Peterse requested to merge yorick/remove-redundant-wal-queries into master
All threads resolved!

What does this MR do and why?

This changes the load balancer to not run redundant WAL related queries when no replicas are in use. These queries are not needed as a single database is always in sync with itself. It should also ensure the new load balancer setup works on Aurora, at least for the time being.

This builds on top of !67773 (merged), as this is easier than basing it on master and having to then rebase/adjust said merge request later on.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Yorick Peterse

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Ghost User
  • Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Corinna Wiesner (@cwiesner) (UTC+2, same timezone as @yorickpeterse) Gabriel Mazetto (@brodock) (UTC+2, same timezone as @yorickpeterse)
    database Mehmet Emin Inac (@minac) (UTC+2, same timezone as @yorickpeterse) Tiger Watson (@tigerwnz) (UTC+11, 9 hours ahead of @yorickpeterse)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report for 6fe7d68c!

    review-qa-smoke: :pencil: test report

  • Yorick Peterse added 1 commit

    added 1 commit

    • 6fe7d68c - Don't run WAL queries when not using replicas

    Compare with previous version

  • A deleted user added databasereview pending label
  • A deleted user added backend label

    added backend label

  • mentioned in issue #342083 (closed)

  • Yorick Peterse mentioned in merge request !71926 (closed)

    mentioned in merge request !71926 (closed)

  • Yorick Peterse resolved all threads

    resolved all threads

  • mentioned in issue #342092 (closed)

  • Yorick Peterse added 786 commits

    added 786 commits

    Compare with previous version

  • Yorick Peterse requested review from @cwiesner and @minac

    requested review from @cwiesner and @minac

  • Corinna Gogolok approved this merge request

    approved this merge request

  • @yorickpeterse As mentioned while reviewing !67773 (merged), I don't have domain knowledge here and did a standalone review. From that point of view, everything looks good.

    I'll pass this back to you in case you want to consider a specific maintainer/someone who was involved in !71736 (merged) to review this to get a review with domain knowledge.

  • Corinna Gogolok removed review request for @cwiesner

    removed review request for @cwiesner

  • :wave: @cwiesner, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Yorick Peterse requested review from @ck3g

    requested review from @ck3g

  • Mehmet Emin INAC requested review from @tigerwnz and removed review request for @minac

    requested review from @tigerwnz and removed review request for @minac

  • Tiger Watson approved this merge request

    approved this merge request

  • added databaseapproved label and removed databasereviewed label

  • Tiger Watson removed review request for @tigerwnz

    removed review request for @tigerwnz

  • Vitali Tatarintev approved this merge request

    approved this merge request

  • Vitali Tatarintev resolved all threads

    resolved all threads

  • Vitali Tatarintev enabled an automatic merge when the pipeline for 5fc7bce5 succeeds

    enabled an automatic merge when the pipeline for 5fc7bce5 succeeds

  • mentioned in commit 1c731e90

  • added workflowcanary label and removed workflowstaging label

  • Sean McGivern mentioned in merge request !72002 (merged)

    mentioned in merge request !72002 (merged)

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #342093 (closed)

  • added devopsdata stores label and removed devopssystems label

  • Please register or sign in to reply
    Loading