Don't run WAL queries when not using replicas
What does this MR do and why?
This changes the load balancer to not run redundant WAL related queries when no replicas are in use. These queries are not needed as a single database is always in sync with itself. It should also ensure the new load balancer setup works on Aurora, at least for the time being.
This builds on top of !67773 (merged),
as this is easier than basing it on master
and having to then rebase/adjust said
merge request later on.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.4
added Category:Cell Sharding Working Group database grouptenant scale typebug labels
assigned to @yorickpeterse
mentioned in issue #220617
- A deleted user
added databasereview pending label
- A deleted user
added backend label
removed backend databasereview pending labels
- Resolved by Yorick Peterse
- Resolved by Yorick Peterse
- Resolved by Yorick Peterse
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Corinna Wiesner ( @cwiesner
) (UTC+2, same timezone as@yorickpeterse
)Gabriel Mazetto ( @brodock
) (UTC+2, same timezone as@yorickpeterse
)database Mehmet Emin Inac ( @minac
) (UTC+2, same timezone as@yorickpeterse
)Tiger Watson ( @tigerwnz
) (UTC+11, 9 hours ahead of@yorickpeterse
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report for 6fe7d68c!review-qa-smoke:
test reportadded 1 commit
- 6fe7d68c - Don't run WAL queries when not using replicas
- A deleted user
added databasereview pending label
- A deleted user
added backend label
mentioned in issue #342083 (closed)
Setting label(s) devopsenablement sectionenablement based on groupsharding.
added devopssystems sectioncore platform labels
cc @iroussos
mentioned in merge request !71926 (closed)
- Resolved by Vitali Tatarintev
@yorickpeterse I am wondering about the chance of this not making it into 14.4? What are your thoughts?
mentioned in issue #342092 (closed)
added 786 commits
-
6fe7d68c...e64d4b68 - 785 commits from branch
master
- 9599f866 - Don't run WAL queries when not using replicas
-
6fe7d68c...e64d4b68 - 785 commits from branch
@yorickpeterse As mentioned while reviewing !67773 (merged), I don't have domain knowledge here and did a standalone review. From that point of view, everything looks good.
I'll pass this back to you in case you want to consider a specific maintainer/someone who was involved in !71736 (merged) to review this to get a review with domain knowledge.
removed review request for @cwiesner
@cwiesner
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @ck3g
- Resolved by Vitali Tatarintev
added databasereviewed label and removed databasereview pending label
added databaseapproved label and removed databasereviewed label
removed review request for @tigerwnz
enabled an automatic merge when the pipeline for 5fc7bce5 succeeds
mentioned in commit 1c731e90
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
mentioned in merge request !72002 (merged)
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!306 (merged)
mentioned in issue #342093 (closed)
added releasedpublished label and removed releasedcandidate label
added devopsdata stores label and removed devopssystems label
added devopstenant scale groupcells infrastructure sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels
added pipeline:mr-approved label