Skip to content

Wait for all pending requests in Monitor settings feature spec

Peter Leitzen requested to merge pl-feature-spec-setting-monitor into master

What does this MR do and why?

This MR attempts to unquarantine a flaky Monitor settings spec (#333665 (closed)). It adds wait_for_all_requests after the "save action".

Although I couldn't reproduce the full issue locally I was able to reproduce some symptoms.

See #333665 (comment 694091528) for more details.

This MR also fixes some (upcoming, currently auto-disabled) RuboCop offenses.

To future reverter

To quarantine the flaky spec again, please only revert 5f2e02e74bad3b8620e3337e93654d63749822ef. Thank you

Screenshots or screen recordings

Before After
projects_settings_for_a_forked_project_settings_monitor_incidents_updates_form_values2 projects_settings_for_a_forked_project_settings_monitor_incidents_updates_form_values

How to set up and validate locally

bin/rspec -f d spec/features/projects/settings/monitor_settings_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports

Loading