Skip to content

Resolve "Integrate rb-ipynbdiff into Gitlab"

Eduardo Bonet requested to merge 341825-integrate-rb-ipynbdiff-into-gitlab into master

Why

Code reviewing Jupyter Notebooks is currently not possible, and a pain point for our users.

Epic: &6589 (closed)

What

Screenshots

Before After
Diff image image
MR image image

Testing

Concerns

  • We understand this is a heavy operation to be added at request time. We are currently exploring alternatives on how to enable special diff rendering for varied file types on this issue: #342143 (closed)
  • At the moment we generate the diff, we have already fetched the info from gitaly, so the limits of file size area already applied at this point
Edited by Eduardo Bonet

Merge request reports