Skip to content

Stop raising errors on validation failure of `UserHighestRole`

Vijay Hawoldar requested to merge vij-fix-validation-errors-for-roles into master

What does this MR do and why?

Through #340268 (closed) we recently noticed that there were thousands of failed sidekiq jobs for the UpdateHighestRoleWorker which were all failing due to the validation error: Validation failed: Highest access level is not included in the list (kibana logs).

This MR seeks to reduce the number of failed jobs by modifiying how the underlying service updates the highest role for a user/member.

Previously, it was using update! which raises an error if it fails validation, this MR adjusts it to remove the bang so that it simply returns false instead.

This should ok in this instance because the service is only called by the worker, which does not care about the result

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vijay Hawoldar

Merge request reports