Skip to content

Remove some issue CSS

Coung Ngo requested to merge cngo-remove-issue-css into master

What does this MR do and why?

This MR removes some issue CSS.

  • Deletes CSS that has no effect
  • Replaces CSS with utility classes
  • There are some UI changes due to changing to Pajamas-compliant spacing
  • Some CSS classes remain in the markup because they're used in tests/other CSS rules. They were not removed as this MR is focused on removing global CSS declarations.

Screenshots or screen recordings

before after
Screenshot_2021-09-30_at_12.14.43_pm Screenshot_2021-09-30_at_12.16.28_pm
Screenshot_2021-09-30_at_12.14.58_pm Screenshot_2021-09-30_at_12.16.37_pm
Screenshot_2021-09-30_at_12.15.24_pm Screenshot_2021-09-30_at_12.16.47_pm
Screenshot_2021-09-30_at_12.15.35_pm Screenshot_2021-09-30_at_12.16.58_pm
Screenshot_2021-09-30_at_12.14.14_pm Screenshot_2021-09-30_at_12.16.15_pm

How to set up and validate locally

  1. Visit any issue such as http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues/1
  2. Visit any milestone such as http://127.0.0.1:3000/h5bp/html5-boilerplate/-/milestones/6
  3. Check the UI

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Coung Ngo

Merge request reports