Skip to content

Surface the error for invalid environment creation

Shinya Maeda requested to merge invalid-environment-not-being-created-should-be-surfaced-to-user-v2 into master

Re-work on !69537 (merged). It removes the problematic code after the corrective actions on FCL

What does this MR do?

This MR resolves the UX issue. Currently, when the system failed to create an environment due to an invalid parameter, it silently falls back to a normal job. However, users should be aware of this failure that their deployment pipelines were not running correctly.

This MR starts failing such jobs by guiding users to fix their pipeline configuration through troubleshooting doc.

Given that this change could disturb users who might rely on the current problematic behavior, it's behind the surface_environment_creation_failure feature flag, which is disabled by default.

Related #21182 (closed)

Screenshots or screen recordings

Peek_2021-09-29_15-26

How to setup and validate locally (strongly suggested)

  1. Create a pipeline with the following config:
deploy:
    stage: deploy
    script: echo
    environment: review/$CI_COMMIT_REF_NAME
  1. Create a merge request with a branch name bug-fix!.
  2. Visit the job page.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Shinya Maeda

Merge request reports