Move cluster agent frontend to Core

What does this MR do and why?

Part of making Cluster Agents available in Core (&6290 (closed)).

These changes will not yet be visible in Core, as there is still a helper method preventing the link to it being rendered:

  # app/helpers/clusters_helper.rb
  def display_cluster_agents?(_clusterable)
    false
  end

  # ee/app/helpers/ee/clusters_helper.rb
  override :display_cluster_agents?
  def display_cluster_agents?(clusterable)
    clusterable.is_a?(Project) && clusterable.feature_available?(:cluster_agents)
  end

We leave this unchanged until everything has been moved, at which point it will serve as a simple way to enable the feature.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

#340355 (closed)

assigned to @tigerwnz

marked this merge request as draft

added groupconfigure [DEPRECATED] label

changed the description

changed title from Draft: Move cluster agent controller and helpers to core to Draft: Move cluster agent frontend to Core

added backend frontend labels

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Scott Stern (@sstern) (UTC-7, 18 hours behind @tigerwnz)	Jose Ivan Vargas (@jivanvl) (UTC-5, 16 hours behind @tigerwnz)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits b8095dcd and 10acf548

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.23 MB	3.23 MB	+3.61 KB	0.1 %
mainChunk	1.88 MB	1.88 MB	-2.98 KB	-0.2 %

Significant Growth: 3

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.projects.on_demand_scans.index	779.22 KB	1.69 MB	+946.38 KB	121.5 %
pages.admin.clusters.index	233.79 KB	1.07 MB	+859.55 KB	367.7 %
pages.groups.clusters.index	294.42 KB	1.09 MB	+826.53 KB	280.7 %

Significant Reduction: 2

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.admin.projects	71.4 KB	54.58 KB	-16.82 KB	-23.6 %
pages.admin.projects.index	148.96 KB	132.7 KB	-16.26 KB	-10.9 %

---

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

Note: We do not have exact data for b8095dcd. So we have used data from: e684ebae.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

added pipeline:run-as-if-foss label

changed milestone to %14.4

added 1 commit

• 46618f57 - Move Cluster Agent frontend to core

Compare with previous version

Allure report

allure-report-publisher generated test report for 10acf548!

review-qa-smoke: test report

Setting label(s) ~"devops::configure" sectionops based on ~"group::configure".

added devopsconfigure [DEPRECATED] sectionops labels

added 359 commits

• 46618f57...52133b3b - 357 commits from branch master
• 7869e1c5 - Move cluster agent controller and views to core
• a4b4dea6 - Move Cluster Agent frontend to core

Compare with previous version

added 442 commits

• a4b4dea6...b51e7099 - 440 commits from branch master
• ede95291 - Move cluster agent controller and views to core
• 1205c31b - Move Cluster Agent frontend to core

Compare with previous version

changed the description

added 360 commits

• 1205c31b...2b828f94 - 359 commits from branch master
• 10acf548 - Move Cluster Agent frontend to core

Compare with previous version

removed backend label

added typemaintenance label

added typefeature label

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

changed the description

@anna_vovchenko can you please review?

marked this merge request as ready

requested review from @anna_vovchenko

approved this merge request

removed review request for @anna_vovchenko

@anna_vovchenko, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

requested review from @jivanvl

resolved all threads

approved this merge request

Looks good to me!

enabled an automatic merge when the pipeline for 5be31052 succeeds

merged

mentioned in commit 61025890

added workflowstaging-canary label

added workflowstaging label and removed workflowstaging-canary label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added releasedcandidate label

removed typefeature label

added releasedpublished label and removed releasedcandidate label

added groupenvironments label and removed groupconfigure [DEPRECATED] label